Skip to content

Commit

Permalink
fix: validate strings after uploading artefacts
Browse files Browse the repository at this point in the history
so that it's easier to debug
  • Loading branch information
Bilb committed Sep 18, 2024
1 parent 47fec1d commit 9b152a4
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/check_for_crowdin_updates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ jobs:
"${{ github.workspace }}/raw_translations" \
"${{ github.workspace }}/desktop/_locales" \
"${{ github.workspace }}/desktop/ts/localization/constants.ts"
- name: Prepare QA strings
run: |
cd ${{ github.workspace }}/desktop/
python ./tools/localization/generateLocales.py --generate-types --print-problems --print-problem-strings --print-problem-formatting-tag-strings --error-on-problems
cd -
- name: Prepare iOS Strings
run: |
python "${{ github.workspace }}/scripts/crowdin/generate_ios_strings.py" \
Expand Down Expand Up @@ -106,6 +101,13 @@ jobs:
overwrite: true
if-no-files-found: warn
retention-days: 7
# It's easier to find what went wrong with some strings if we can get the files from the artefact upload step above.
# The job will still be marked as failed and no Pull Requests will be made.
- name: Prepare QA strings
run: |
cd ${{ github.workspace }}/desktop/
python ./tools/localization/generateLocales.py --generate-types --print-problems --print-problem-strings --print-problem-formatting-tag-strings --error-on-problems
cd -
- name: Upload QA artefacts
uses: actions/upload-artifact@v4
with:
Expand All @@ -117,6 +119,8 @@ jobs:
if-no-files-found: warn
retention-days: 7



# Not sure why yet, but uploading artefacts after creating the pull requests
# seems to only include a part of what should be in.
# As a dirty fix we upload the artefacts first, and then make the pull request
Expand Down

0 comments on commit 9b152a4

Please sign in to comment.