Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back button in navigation bar when navigating from communities to message author's DM #3101

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

VityaSchel
Copy link

@VityaSchel VityaSchel commented May 9, 2024

First time contributor checklist:

Contributor checklist:

Description

I have added returnToConversation state property that has ReturnToConversationProps type. It is where information stored about where to navigate when user presses back button in navigation bar when returning from direct messages conversation with Community participant.

telegram-cloud-photo-size-2-5325704201331927275-y

I have used existing BackButton component and openConversationToSpecificMessage function to navigate user exactly where they were before pressing avatar of some other user.

Also I handled cases like deleting returning conversation while in DMs (user navigates to someone's DM -> deletes community) and deleting current selected conversation while having return state (user navigated to someone's DM conversation -> deletes it) — in both cases returnToConversation is reset, hiding back button.

See #2595

@pottsandpans pottsandpans added the Jira This ticket is being tracked in Jira label May 21, 2024
@pottsandpans
Copy link
Collaborator

This will be tracked internally on Jira (SES-1940) for code review.``

@Bilb Bilb changed the base branch from clearnet to unstable September 30, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira This ticket is being tracked in Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants