Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent sending messages with attachments multiple times by adding current state check #3100

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

VityaSchel
Copy link

First time contributor checklist:

Contributor checklist:

Description

I have tested issue described in #2744 and figured out that the problem was in onSendMessage() function taking long time to complete (and thus reset composition box input) because of getFiles() async function which scales and stores attachments locally before sending.

I have added a simple check to CompositionBoxInner class that prevents user from sending multiple messages. I think the best solution would be to move all attachments logic to sending stage so that visually messages would be sent immediately, but I didn't want to change a lot of logic.

Related: #2744

@pottsandpans pottsandpans added the Jira This ticket is being tracked in Jira label May 21, 2024
@pottsandpans
Copy link
Collaborator

This will be tracked internally on Jira (SES-1939) for code review.

@Bilb Bilb changed the base branch from clearnet to unstable September 30, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira This ticket is being tracked in Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants