Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download all attachments to messages. #2928

Draft
wants to merge 8 commits into
base: unstable
Choose a base branch
from

Conversation

RubenGarcia
Copy link

@RubenGarcia RubenGarcia commented Sep 17, 2023

docs: Document additional packages needed in ubuntu
fix: Changes to save multiple attachments in same message with a different name.

First time contributor checklist:

Contributor checklist:

Description

This merge request builds on
#2917
(#2743)
and adds the possibility to download all attachments to a directory in one go.

docs: Document additional packages needed in ubuntu
fix: Changes to save multiple attachments in same message with a different name.
* fix: yarn ready fixes
@Bilb
Copy link
Collaborator

Bilb commented Oct 16, 2023

Hey, could we instead of relying on those chrome experimental features,

  • show a picker to choose the folder,
  • get the full path of that folder,
  • send that folder, a Array<{filename:string, plaintext: Uint8Array} to the main side of electron and have it create the files and fill the content of it?

@RubenGarcia
Copy link
Author

RubenGarcia commented Oct 16, 2023

Hey, could we instead of relying on those chrome experimental features,

* show a picker to choose the folder,

* get the full path of that folder,

* send that folder, a Array<{filename:string, plaintext: Uint8Array} to the main side of electron and have it create the files and fill the content of it?

The last part I don't know how to do.
I only activate the experimental features so I have access to the functions which save to disk in the background. I suppose they be available without enabling experimental once electron is updated, so we can wait until then and remove the line that enables experimental features.

@Bilb
Copy link
Collaborator

Bilb commented Oct 17, 2023

ok, I'll mark this PR as draft until then

@Bilb Bilb marked this pull request as draft October 17, 2023 02:27
@RubenGarcia
Copy link
Author

v25.8.4 still needs the request for experimental features.

@KeeJef
Copy link
Collaborator

KeeJef commented Mar 20, 2024

To ensure I understand correctly, this feature allows users to download all attachments of a message by selecting an option from the context menu that appears when clicking on a message with multiple attachments. Does this action prompt the user to choose a save location via a file picker, or are the attachments automatically saved to a default location?

Does this still rely on Chrome experimental features?

@RubenGarcia
Copy link
Author

It asks the user to select a directory.
I think the feature is still marked as experimental, but I have not checked lately.

@Bilb Bilb changed the base branch from clearnet to unstable September 30, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants