(dev) Fix stream segfault; downgrade common warning logs #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stream can get destroyed before the send_impl's lambda fires. This fixes it by adding a Stream weak ptr to avoid that when send() is not already inside the event loop.
These two logs, in particular:
Server could not verify regular token!
Error: connection could not be created
fire incredibly often in storage server (which, at default log level,
has quic at warning level), most likely because of expired (or sleeping)
incoming quic connections.
These are neither problems to be fixed, nor problems that even can be
fixed, so warning seems too high for them and so this downgrades them to
info level.
tewinget
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev branch version of #143