Make sure sent_requests have a keep-alive #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A close at just the wrong time could result in an invalid string_view still pending on a Stream. This seems too problematic to have the "no ownership" parameter as a default argument, so I've made it explicit (and added nullptr to the many test suites places previously using it implicitly).
|
No test case because I haven't a clue how I could trigger this manually. I'm also not 100% sure that this is the issue we saw in Lokinet, but it seems to me that it could be, particularly when combined with the Lokinet close-one-direction logic + RC gossiping. |
dr7ana
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A close at just the wrong time could result in an invalid string_view still pending on a Stream.
This seems too problematic to have the "no ownership" parameter as a default argument, so I've made it explicit (and added nullptr to the many test suites places previously using it implicitly).