Devnet #93
Draft
Devnet #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the beneficiary after the contract is finalized has no effect because the beneficiaries have already been committed to the contract and are locked in. This is preventable by checking the status of the contract before updating the contract. Note that when the operator contributes, the contract transitions into `OpenForPublicContrib` immediately before the beneficiary is updated. This then means that the valid states that are observed for a beneficiary to be updatable is exactly 2 states, `OpenForPublicContrib` and `WaitForFinalized`.
We can directly handle a reset by processing the request directly rather than deferring to removeAndRefundContributor which presupposes that the intention of the call is to remove exactly 1 contributor which has side-effects that waste gas as we're going to ultimately delete the contributor which nullifies said busy work.
…ting-wrong-operator' into devnet
- Adds a devnet upgrade script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for tracking our internal devnet, which is currently running on the latest PRs and WIP branches as merged here.
Not for review/merging until after the included relevant PRs are finalized and merged.