Fix multi-contrib nodes setting contract as operator of node #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
reviewed
Oct 16, 2024
| sn.operator = contributors[0].staker.addr; | ||
| for (uint256 i = 0; i < contributors.length; i++) | ||
| sn.operator = operator; | ||
| for (uint256 i = 0; i < contributors.length; ) { |
There was a problem hiding this comment.
Why did the i++ get dropped? (I don't see how this isn't an infinite loop without it)
There was a problem hiding this comment.
Oh, I see, I think this was a merge conflict with the ongoing audit response branch (which drops the i++ but has an unchecked { i += 1; } in the body).
darcys22
reviewed
Oct 16, 2024
contracts/ServiceNodeRewards.sol
Outdated
| sn.contributors.push(contributors[i]); | ||
| unchecked { i += 1 }; |
darcys22
approved these changes
Oct 16, 2024
Doy-lee
force-pushed
the
doyle-fix-multi-contrib-attributing-wrong-operator
branch
from
c7a7c11
to
7a24a9e
Compare
|
Thanks, have squashed the bugs back to the base commit (and fixed the syntax error in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my integration tests curiously multi-contributor contracts were failing until I realised that we were using
msg.senderas the operator which is incorrect in the multi-contributor flow.When you have a multi-contributor contract, that calls
addBLSPublicKeyon the rewards contract on the operator's behalf. This means thatmsg.senderis set to the multi-contribution contract. Then, inaddBLSPublicKeywe'd use themsg.sendertovalidateProofOfPossessionbut also emit aNewServiceNodeV2log with the contract address.This is incorrect and would prevent the operator from being able to exit the node. It'd also fail checks in core where it expects the 1st contributor to be the operator. The fix here is to correctly use
msg.senderfor transferring the stake and the 1st contributor as the operator for the SN metadata.