Add public function to retrieve all contributions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the requirement that new contributions from existing contributors satisfy the minimum staking requirement. Such contributors will already satisfy the minimum requirement (because it would have been checked by the initial contribution), and so this doesn't need to be checked. *Not* checking it allows contributors to increase their stake in a pending SN with any amount they like. The current contract behaviour was mimicking the Oxen behaviour which *does* impose the minimum on top-ups, but that was because of a implementation detail (realistically, a limitation, perhaps categorizable as a bug) in Oxen where the minimum was defined not by the number of distinct contributors, but rather than the number of locked key images which always increased with each top-up, and so Oxen top-ups really did take up a contribution spot.
Various packages were complaining about being outdated in various places; this updates the offenders.
It's not clear how this was *ever* working because the default test
path is `./test/**/*.js`, which was picking up
`test/cpp/external/ethyl/external/oxen-logging/fmt/doc/_static/bootstrap.min.js`
which failed to compile/run with:
An unexpected error occurred:
Error: Bootstrap's JavaScript requires jQuery
at Object.<anonymous> (/home/jagerman/src/eth-sn-contracts/test/cpp/external/ethyl/external/oxen-logging/fmt/doc/_static/bootstrap.min.js:6:37)
at Module._compile (node:internal/modules/cjs/loader:1364:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
at Module.load (node:internal/modules/cjs/loader:1203:32)
at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
at Module.require (node:internal/modules/cjs/loader:1231:19)
at require (node:internal/modules/helpers:177:18)
at /home/jagerman/src/eth-sn-contracts/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/mocha.js:414:36
at Array.forEach (<anonymous>)
at Mocha.loadFiles (/home/jagerman/src/eth-sn-contracts/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/mocha.js:411:14)
ELIFECYCLE Test failed. See above for more details.
This fixes it to only include test/unit-js when looking for hardhat
tests to run.
Without this function there's no nice, reliable way to get the current contributors: 1) you have to fetch the length, then loop to fetch the next address, then fetch the next contribution, and so on. This isn't nice for the external user. 2) the approach in 1) isn't atomic and so if any mutating contract call happens while iterating you will end up with a wrong (not just outdated) result.
|
Also LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Builds on top of #75; only the final commit here is relevant to this PR)
This adds a function to get all contributors and contributions in one-shot. Without this function there's no nice, reliable way to get the current contributors:
you have to fetch the length, then loop to fetch the next address, then fetch the next contribution, and so on. This isn't nice for the external user.
the approach in 1) isn't atomic and so if any mutating contract call happens while iterating you will end up with a wrong (not just outdated) result.