Extra functionality to improve reusable contracts #68
Conversation
darcys22
changed the title
There was a problem hiding this comment.
This looks like some precursor work for the larger reusable contracts change. I suspect we'll be getting rid of the finalized flag which is still used here, and, we might just end up with a very chunky reset function that lets you assign all the parameters at once.
If we end up down that route then it'd remove the need for individual setter functions. But for now this looks fine.
| function updateBLSPubkey(BN256G1.G1Point memory newBlsPubkey) public onlyOperator { | ||
| require(!finalized, "Cannot update pubkey: Node has already been finalized."); | ||
| require(contributorAddresses.length == 1, "Cannot update pubkey: Other contributors have already joined."); | ||
| require(contributorAddresses[0] == operator, "Cannot update pubkey: Operator has not contributed yet."); |
There was a problem hiding this comment.
The operator has to be at slot 0, I think we can omit this. Shouldn't be possible to hit. Though if we keep it, the error string is inaccurate, it's more that there's an unexpected contributor in the 0th slot (and they've somehow as a non-operator already contributed for them to be in the array).
Similarly with the same require in updateServiceNodeParams
darcys22
force-pushed
the
reusable-contract
branch
from
c8d57d5
to
9185fbe
Compare
No description provided.