Cosmetic fixes to confusing event parameter names #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few events have an address parameter named "recipient" which was confusing as the events in question have little to do with receiving anything. This updates them to a more descriptive name. This was spreading into oxen-core, where attempting to preserve naming consistency with the smart contract led to similar confusion of the values being captured in the eth transactions. (This is purely cosmetic as no types in the events are being changed and event signatures depend only on parameter types, not parameter names).
jagerman
added a commit
to jagerman/loki
that referenced
this pull request
Aug 10, 2024
This implements a confirmation mechanism into the pulse quorum to enhance the security of pulse blocks without introducing desyncing of the Oxen chain to achieve consensus. The general design implemented here is explained in the `docs/sent-l2-confirmation/sent-confirmations.md` document (and so see that for details rather than this commit message). Other smaller changes included here that intersect (but aren't directly part of the confirmation mechanism): - Combine the virtually identical `tx_extra_ethereum_new_service_node` and `NewServiceNodeTx` instead a single 'eth::event::NewServiceNode`, and likewise for removal requests and removals. - Update the naming of L2 events to match the more informative names in oxen-io/eth-sn-contracts#58 - Increase L2 refresh times to once per minute. - Remove useless pass-through wrapper functions for txpool operations from blockchain.cpp, and just have tx_pool call directly into the db via blockchain's `db()` reference. - Remove l2 monotonic height checks from consensus consideration; they are dangerous in that a malicious quorum could stall the chain by putting an excessive value that honest nodes couldn't follow. - Various related code cleanup in passing. - renamed some functions such as `get_locked_key_image_unlock_height` that have become rather misnamed by the eth transition. - Simplify tx_pool sorting which was, for completely inexplicable reasons, a pair<tuple<A,B,C>, D> rather than a tuple<A,B,C,D>. - Refomatting
jagerman
added a commit
to jagerman/loki
that referenced
this pull request
Aug 16, 2024
This implements a confirmation mechanism into the pulse quorum to enhance the security of pulse blocks without introducing desyncing of the Oxen chain to achieve consensus. The general design implemented here is explained in the `docs/sent-l2-confirmation/sent-confirmations.md` document (and so see that for details rather than this commit message). Other smaller changes included here that intersect (but aren't directly part of the confirmation mechanism): - Combine the virtually identical `tx_extra_ethereum_new_service_node` and `NewServiceNodeTx` instead a single 'eth::event::NewServiceNode`, and likewise for removal requests and removals. - Update the naming of L2 events to match the more informative names in oxen-io/eth-sn-contracts#58 - Increase L2 refresh times to once per minute. - Remove useless pass-through wrapper functions for txpool operations from blockchain.cpp, and just have tx_pool call directly into the db via blockchain's `db()` reference. - Remove l2 monotonic height checks from consensus consideration; they are dangerous in that a malicious quorum could stall the chain by putting an excessive value that honest nodes couldn't follow. - Various related code cleanup in passing. - renamed some functions such as `get_locked_key_image_unlock_height` that have become rather misnamed by the eth transition. - Simplify tx_pool sorting which was, for completely inexplicable reasons, a pair<tuple<A,B,C>, D> rather than a tuple<A,B,C,D>. - Refomatting
Doy-lee
pushed a commit
to oxen-io/oxen-core
that referenced
this pull request
Aug 21, 2024
This implements a confirmation mechanism into the pulse quorum to enhance the security of pulse blocks without introducing desyncing of the Oxen chain to achieve consensus. The general design implemented here is explained in the `docs/sent-l2-confirmation/sent-confirmations.md` document (and so see that for details rather than this commit message). Other smaller changes included here that intersect (but aren't directly part of the confirmation mechanism): - Combine the virtually identical `tx_extra_ethereum_new_service_node` and `NewServiceNodeTx` instead a single 'eth::event::NewServiceNode`, and likewise for removal requests and removals. - Update the naming of L2 events to match the more informative names in oxen-io/eth-sn-contracts#58 - Increase L2 refresh times to once per minute. - Remove useless pass-through wrapper functions for txpool operations from blockchain.cpp, and just have tx_pool call directly into the db via blockchain's `db()` reference. - Remove l2 monotonic height checks from consensus consideration; they are dangerous in that a malicious quorum could stall the chain by putting an excessive value that honest nodes couldn't follow. - Various related code cleanup in passing. - renamed some functions such as `get_locked_key_image_unlock_height` that have become rather misnamed by the eth transition. - Simplify tx_pool sorting which was, for completely inexplicable reasons, a pair<tuple<A,B,C>, D> rather than a tuple<A,B,C,D>. - Refomatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few events have an address parameter named "recipient" which was confusing as the events in question have little to do with receiving anything. This updates them to a more descriptive name.
This was spreading into oxen-core, where attempting to preserve naming consistency with the smart contract led to similar confusion of the values being captured in the eth transactions.
(This is purely cosmetic as no types in the events are being changed and event signatures depend only on parameter types, not parameter names).