Remove timestamp argument from RewardRatePool query functions #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the "interest" term a little confusing as the pool doesn't earn/pay interest, but rather pays a portion of its princpal. (No logic changes.)
Our announced reward payout is 14% annually of the pool, which works out to ~15.1% when compounded regularly. This updates the amount, and adds documentation of how that value is derived from the 14% target.
Tests the the compounding effect on the simple payout rate achieves (within reasonable error) the intended 14% target when compounded daily or monthly.
Requiring the timestamp here causes problems with oxend because it means we can't realistically pre-fetch rewards amounts until we get the timestamp from oxen. That's a problem because we can't pre-fetch the reward data for verification (because it needs the timestamp that goes into the block), which means in order to validate blocks we'd have to stop during block processing and make (and wait for) a contract call to come back. Removing the timestamp makes this a lot easier because it lets us query the reward rate in advance by only querying every few minutes (at predefined height intervals the network agrees on) and because it now depends on the block timestamp, the value will be the same for anyone fetching it.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring the timestamp here causes problems with oxend because it means we can't realistically pre-fetch rewards amounts until we get the timestamp from oxen.
That's a problem because we can't pre-fetch the reward data for verification (because it needs the timestamp that goes into the block), which means in order to validate blocks we'd have to stop during block processing and make (and wait for) a contract call to come back.
Removing the timestamp makes this a lot easier because it lets us query the reward rate in advance by only querying every few minutes (at predefined height intervals the network agrees on) and because it now depends on the block timestamp, the value will be the same for anyone fetching it.
(This is based on top of #43; only the last commit here is the intended part of this commit).