Add the old beneficiary to the log for UpdateStakerBeneficiary

oxen-io · Oct 4, 2024 · c2d3d9a · c2d3d9a
1 parent 3e4b471
commit c2d3d9a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/contracts/ServiceNodeContribution.sol b/contracts/ServiceNodeContribution.sol
@@ -213,12 +213,14 @@ contract ServiceNodeContribution is Shared, IServiceNodeContribution {
     function updateBeneficiary(address newBeneficiary) external { _updateBeneficiary(msg.sender, newBeneficiary); }
 
     function _updateBeneficiary(address stakerAddr, address newBeneficiary) private {
-        bool updated   = false;
-        uint256 length = _contributorAddresses.length;
+        address oldBeneficiary = address(0);
+        bool updated           = false;
+        uint256 length         = _contributorAddresses.length;
         for (uint256 i = 0; i < length; i++) {
             IServiceNodeRewards.Staker storage staker = _contributorAddresses[i];
             if (staker.addr == stakerAddr) {
                 updated            = true;
+                oldBeneficiary     = staker.beneficiary;
                 staker.beneficiary = newBeneficiary;
                 break;
             }
@@ -227,7 +229,7 @@ contract ServiceNodeContribution is Shared, IServiceNodeContribution {
         if (!updated)
             revert NonContributorUpdatedBeneficiary(stakerAddr);
 
-        emit UpdateStakerBeneficiary(stakerAddr, newBeneficiary);
+        emit UpdateStakerBeneficiary(stakerAddr, oldBeneficiary, newBeneficiary);
     }
 
     function contributeFunds(uint256 amount, BeneficiaryData memory data) external { _contributeFunds(msg.sender, data, amount); }

diff --git a/contracts/interfaces/IServiceNodeContribution.sol b/contracts/interfaces/IServiceNodeContribution.sol
@@ -45,7 +45,7 @@ interface IServiceNodeContribution {
     event OpenForPublicContribution(uint256 indexed serviceNodePubkey, address indexed operator, uint16 fee);
     event Filled                   (uint256 indexed serviceNodePubkey, address indexed operator);
     event WithdrawContribution     (address indexed contributor, uint256 amount);
-    event UpdateStakerBeneficiary  (address indexed staker, address beneficiary);
+    event UpdateStakerBeneficiary  (address indexed staker, address oldBeneficiary, address newBeneficiary);
 
     //////////////////////////////////////////////////////////////
     //                                                          //