enfore a minimum liquidator ratio

oxen-io · Sep 9, 2024 · 2030c4f · 2030c4f
1 parent febf756
commit 2030c4f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/contracts/ServiceNodeRewards.sol b/contracts/ServiceNodeRewards.sol
@@ -69,6 +69,7 @@ contract ServiceNodeRewards is Initializable, Ownable2StepUpgradeable, PausableU
         uint256 recipientRatio_
     ) public initializer {
         if (recipientRatio_ < 1) revert RecipientRewardsTooLow();
+        if (liquidatorRewardRatio_< 1) revert LiquidatorRewardsTooLow();
         isStarted = false;
         totalNodes = 0;
         blsNonSignerThreshold = 0;
@@ -172,6 +173,7 @@ contract ServiceNodeRewards is Initializable, Ownable2StepUpgradeable, PausableU
     error InvalidBLSSignature();
     error InvalidBLSProofOfPossession();
     error LeaveRequestTooEarly(uint64 serviceNodeID, uint256 timestamp, uint256 currenttime);
+    error LiquidatorRewardsTooLow();
     error MaxContributorsExceeded();
     error MaxClaimExceeded();
     error MaxPubkeyAggregationsExceeded();

diff --git a/scripts/deploy-local-test.js b/scripts/deploy-local-test.js
@@ -35,7 +35,7 @@ async function main() {
         await rewardRatePool.getAddress(),         // foundation pool address
         120_000_000_000,                           // staking requirement
         10,                                        // max contributors
-        0,                                         // liquidator reward ratio
+        1,                                         // liquidator reward ratio
         0,                                         // pool share of liquidation ratio
         1                                          // recipient ratio
     ]);

diff --git a/test/unit-js/ServiceNodeRewardsTest.js b/test/unit-js/ServiceNodeRewardsTest.js
@@ -41,7 +41,7 @@ describe("ServiceNodeRewards Contract Tests", function () {
             await foundationPool.getAddress(),         // foundation pool address
             staking_req,                    // testnet staking requirement
             10,                             // max contributors
-            0,                              // liquidator reward ratio
+            1,                              // liquidator reward ratio
             0,                              // pool share of liquidation ratio
             1                               // recipient ratio
             ]);