-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unzip extension #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
51f1563
to
042f6b1
Compare
eaebc34
to
7680828
Compare
474fcb4
to
7efbcb6
Compare
Some nitpicks:
Other than that: 🚀 |
7efbcb6
to
7ae7c70
Compare
@tbsbdr What do you think? I kinda like the idea of showing a message that it might take a while.
Yep, we should definitely get this going for this repo: #40
👍
I just tried it, the app gets correctly shipped by oCIS for me. Extracting doesn't work though because the Web version bundled with oCIS is not up to date. Also, I get an error in the cast app:
True, that should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly - I have one UX related question though:
- zip a subfolder of the linux folder (
alchemy
inmips
) - upload
alchemy.zip
to personal space - right click and
Extract here
expected behaviour
Folder alchemy
gets created as root level wrapping folder where the content of the zip file gets extract to.
actual behaviour
Folder alchemy (1)
gets created as root level wrapping folder, although there is no other content than the alchemy.zip
file.
7ae7c70
to
96b55d6
Compare
closes owncloud/web#11264