restructure configuration and autogenerate values list #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkloucek
force-pushed
the
config-documentation
branch
6 times, most recently
from
f530e7a
to
82521be
Compare
wkloucek
force-pushed
the
config-documentation
branch
from
82521be
to
c74a19a
Compare
wkloucek
requested review from
dragonchaser,
rhafer and
mmattel
and removed request for
dragonchaser
dragonchaser
requested changes
Jul 15, 2022
| * 1.22.0 | ||
| * 1.23.0 | ||
| * 1.24.0 | ||
| ~1.20.0 || ~1.21.0 || ~1.22.0 || ~1.23.0 || ~1.24.0 |
There was a problem hiding this comment.
This is a bit unreadable after rendering, can we move this into a code block maybe?
There was a problem hiding this comment.
I've added a code block. Ideally I wanted to split the versions and put them in a list. But one can only access it with {{ template "chart.kubeVersion" . }}, which cannot be assigned to a variable and therefore cannot be splitted... :-/
dragonchaser
approved these changes
Jul 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING PR
The per services configuration has been moved to a
services:section.Furthermore we now autogenerate the values list from the values.yaml comments.
fixes chart generation part of #3 (comment)