Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with OCaml 5.2.0 and update documentation #677

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Fix compilation with OCaml 5.2.0 and update documentation #677

merged 8 commits into from
Jul 31, 2024

Conversation

jzstark
Copy link
Collaborator

@jzstark jzstark commented Jul 28, 2024

This PR includes three parts:

  1. Fix compilation error due to the introduction of Float16 type in new OCaml version
  2. Fix math notations in the existing inline documentation
  3. Add inline documentation to a part of existing functions that do not have doc yet

@jzstark jzstark requested a review from ryanrhymes July 28, 2024 21:07
@jzstark jzstark merged commit 08375ec into main Jul 31, 2024
26 checks passed
@jzstark jzstark deleted the update branch August 29, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanrhymes ryanrhymes ryanrhymes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzstark @ryanrhymes