scripts: log-collector: Add ovs open-flows dump to log results #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceara
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks, @LorenzoBianconi, for the contribution! I have a couple of comments though.
| @@ -9,11 +9,13 @@ for c in $(podman ps --format "{{.Names}}" --filter "name=${node_name}"); do | |||
| mkdir ${host}/$c | |||
| podman exec $c ps -aux > ${host}/$c/ps | |||
| podman exec $c bash -c 'touch /tmp/process-monitor.exit && sleep 5' | |||
| podman exec $c bash -c 'ovs-ofctl dump-flows br-int > /tmp/open-flows.log' | |||
There was a problem hiding this comment.
I think it's useful to also dump groups:
ovs-ofctl dump-groups br-int
There was a problem hiding this comment.
Won't this generate way too much data for large scale runs (e.g., 500 nodes)? Should we somehow make sure we only collect data from a subset of the nodes?
There was a problem hiding this comment.
@dceara we will have file for each of the nodes, in this way we can just look at what it is meaningful. Do you prefer to define a subset of the node list?
There was a problem hiding this comment.
I think it's useful to also dump groups:
ovs-ofctl dump-groups br-int
@dceara ack, I will fix it
Signed-off-by: Lorenzo Bianconi <[email protected]>
LorenzoBianconi
force-pushed
the
dump-open-flows
branch
from
dbcabce
to
5cb4876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ovs open-flows dump to log results folder