Improve error message : add request ID #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theredcat
requested review from
rbeuque74,
deathiop,
a-beudin,
amstuta,
mxpetit and
yomovh
as code owners
amstuta
reviewed
Apr 11, 2024
ovh/helpers/helpers.go
Outdated
| d.SetId("") | ||
| return nil | ||
| } | ||
|
|
||
| return fmt.Errorf("calling %s:\n\t %s", endpoint, err.Error()) | ||
| return fmt.Errorf("calling %s:\n\t %s Query ID : %s", endpoint, err.Error(), errOvh.QueryID) |
There was a problem hiding this comment.
you should use errOvh.QueryID only if we're sure that ok is true, something like:
var queryID string
if ok {
queryID = errOvh.QueryID
}
mxpetit
previously requested changes
Oct 15, 2024
theredcat
force-pushed
the
patch-1
branch
2 times, most recently
from
30dc0ba
to
a540ed2
Compare
|
Thanks for your contribution @theredcat :) |
amstuta
approved these changes
Oct 17, 2024
amstuta
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add request ID in error message when CheckDeleted function is used. This information is systematically asked by the support but isn't available anywhere in a normal run
Type of change
How Has This Been Tested?
Just waited for one of the occasionnal API fail