Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guide: Obtaining Source IP in Octavia on OVHcloud without Kubernetes CCM #6704

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

KebirHakim
Copy link
Contributor

No description provided.

@Y0Coss Y0Coss requested a review from scraly August 7, 2024 12:20
@Y0Coss
Copy link
Collaborator

Y0Coss commented Aug 7, 2024

@KebirHakim , you can delete the fr-fr file. All the K8S documentation is only available in English.

@Y0Coss Y0Coss added the Guide creation The Pull Request contains at least 1 new guide (meta.yaml and index edition needed) label Aug 7, 2024
@scraly
Copy link
Contributor

scraly commented Aug 8, 2024

General remark: Octavia is the technology created by Openstack, but the product used is Public Cloud Load Balancer :)

@scraly
Copy link
Contributor

scraly commented Aug 8, 2024

Second remark:
image

Why the name contains "proxy protocol"? Is it a wrong copy/paste?
I think it can be better to name the folder accrding to the goal of the guide: public-cloud-load-balancer-source-ip (it can be an idea for example)

the name of the folder should be aso fixed in index.md file.

pages/index.md Outdated Show resolved Hide resolved
}
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank lines

Copy link
Contributor

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add few suggestions

Copy link
Contributor

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my suggestions
thanks! :)

+----------------------+--------------------------------------+
```

#### 3. Add members to the pool (the backend instances)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in requierements sections: create 2 instances

#### 2. Send an HTTP request to the LoadBalancer's VIP address

```bash
curl http://192.168.0.57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example:

curl $VIP_ADDRESS

#### 1. Get the VIP address of the LoadBalancer

```bash
openstack loadbalancer show my-loadbalancer -c vip_address -f value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example:

VIP_ADDRESS=$(openstack loadbalancer show my-loadbalancer -c vip_address -f value)
echo $VIP_ADDRESS

@@ -570,6 +570,7 @@
+ [First steps with preinstalled applications](public_cloud/compute/apps_first_steps)
+ [Starting an instance on an attached volume](public_cloud/compute/start_instance_on_attached_volume)
+ [Shelve or pause an instance](public_cloud/compute/suspend_or_pause_an_instance)
+ [Obtaining Source IP in Octavia](public_cloud/containers_orchestration/managed_kubernetes/Octavia_Tutorial_Add_proxy_protocol)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this guide in the /managed-kubernetes/ folder and now located under the Compute category in the index?
Shouldn't it be physically relocated in the public_cloud/public_cloud_network_services folder and under the [Technical resources](public-cloud-network-technical-resources) category (from line 662) in the index?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yomovh , any opinion on the right index location for this new guide?

…/Octavia_Tutorial_Add_Proxy_Protocol/guide.fr-fr.md
Copy link
Collaborator

@Y0Coss Y0Coss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the Guides Team can review this content, you need to align/fix the following:

  • guide folder location: /managed_kubernetes/
    VS

  • guide index location: /compute/

  • guide title: "Obtaining Source IP in Public Cloud Load Balancer"
    VS

  • guide folder naming: Octavia_Tutorial_Add_Proxy_Protocol

  • guide full_slug: public-cloud-managed-kubernetes-octavia-tutorial-add-proxy-protocol

@Y0Coss Y0Coss added the Edition needed Content needs edition from the author before Quality Check by the Guides Team can start/resume label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edition needed Content needs edition from the author before Quality Check by the Guides Team can start/resume Guide creation The Pull Request contains at least 1 new guide (meta.yaml and index edition needed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants