Fix loading avatars from Dropbox due to URLs containing parameters #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleglass
added
needs CR
ksuprynowicz
approved these changes
Sep 18, 2023
ksuprynowicz
added
CR approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the FST parser, which chokes on
=characters in URLs.With this avatars hosted on Dropbox should load correctly.
Here's an URL to test with: https://www.dropbox.com/scl/fi/9tcraie3picd576o4kcpi/avatar-dropbox-good-dl3.fst?rlkey=o03ebkw7l19bzpvvw7qrg6cow&dl=1
For it to work, you must use the download link, with the
dl=1at the end. The actual FST has to contain a full URL for the model, also with the download link:Note that the "rlkey" and the URL don't match in these two. Dropbox URLs are random and can't be used with the "texdir" and similar relative paths. Full paths must be used everywhere.
Closes #633