Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Smoothing #579

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Conversation

Armored-Dragon
Copy link
Member

@Armored-Dragon Armored-Dragon commented Aug 19, 2023

Resolves #567 and resolves #571.
Existing applications in the repo are incomplete, contain broken links, or use non-implemented features.
This will consolidate existing "in-dev" applications into a single functional app.

Uses valid track points
Relocated to /developer
Better UI
Settings persistance
Refactored everything
New UI
@Armored-Dragon Armored-Dragon marked this pull request as ready for review August 22, 2023 09:42
@Armored-Dragon
Copy link
Member Author

I would greatly appreciate thorough testing before this is merged. I had some issues with settings, please let me know if the app settings are not initialized correctly.

@Armored-Dragon Armored-Dragon changed the title FBT Smoothing Fix Avatar Smoothing Aug 22, 2023
@Armored-Dragon
Copy link
Member Author

Also, in this pull request I removed a file 'AccelerationFilter.js'. Currently in the master branch it tries to use "accelerationLimiter" type of filter. There appears to be code referencing it but it is not mentioned in the docs, nor is this exposed via API.

@ksuprynowicz ksuprynowicz added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Aug 22, 2023
@ksuprynowicz
Copy link
Member

Both accelerationLimiter and exponentialSmoothing filters are registered in libraries/controllers/src/controllers/impl/Filter.cpp. Do the scripts using them not work currently?

@Armored-Dragon
Copy link
Member Author

accelerationLimiter does not work at all and logs an error relating to 'accelerationLimiter' not being a valid 'type'. exponentialSmoothing may work; There is no UI to interact with it as the HTML link does not exist. I did originally use a modified version of this file to originally test to make sure 'exponentialSmoothing' was a valid type.

@ksuprynowicz
Copy link
Member

Can we move these to script-archive instead of deleting? They might become useful in the future if we figure out why accelerationLimiter is not available on script engine side.

@SilverfishVR
Copy link
Contributor

I think @daleglass has the missing files from HF_Public:
/tony/html/accelerationFilterApp.html
/tony/icons/tpose-i.svg
/tony/icons/tpose-a.svg

But if accelerationLimiter is broken it's not much use.
🤔 perhaps there was another app, on the marketplace mayhaps.

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Sep 22, 2023
@ksuprynowicz ksuprynowicz merged commit 57a2ebb into overte-org:master Sep 22, 2023
2 of 5 checks passed
@Armored-Dragon Armored-Dragon deleted the FBT-Smoothing-Fix branch November 3, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR approved This pull request has been successfully code reviewed
Projects
None yet
3 participants