Fix most of the crash causes on script engine reload/shutdown #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
added
bug
AnotherFoxGuy
approved these changes
Aug 18, 2023
|
For me, events are repeated 5 times, so for each |
|
@SilverfishVR I just tested the newest version and it looks like issue with entity scripts is fixed. If you have some time please let me know if it works on newest build for you too. |
daleglass
approved these changes
Aug 29, 2023
|
👍 It does indeed seem to work now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script reload works pretty well now.
I also temporarily disabled forced termination of script threads because it was completely unsafe and would always cause crashes. We need to do it in a better way in later PR.