Added null pointer check for asQuickItem() #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
added
needs CR
daleglass
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Isn't this a bit inefficient? You're calling asQuickItem() twice now,.
Also, I think such code tends to look suspicious, because what if it returns different things on successive calls? Now the person reading the code has to look at the implementation to make sure that can't happen.
daleglass
approved these changes
Aug 18, 2023
ksuprynowicz
added
CR approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes random crashes when closing script log window.