support more procedural shader uniform types, including arrays #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HifiExperiments
added
enhancement
HifiExperiments
commented
Oct 22, 2024
| @@ -356,16 +356,53 @@ void Procedural::prepare(gpu::Batch& batch, | |||
| } | |||
| } | |||
| // Then fill in every reflections the new custom bindings | |||
| int customSlot = procedural::slot::uniform::Custom; | |||
| size_t customSlot = procedural::slot::uniform::Custom; | |||
| _slotMap.clear(); | |||
There was a problem hiding this comment.
per the spec, float/vec2/vec3/vec4/mat3/mat4 take up a single uniform slot, whereas array types take up as many as the length of the array.
we compute how many slots each uniform is going to need up here, and then in Procedural::setupUniforms we can just look it up
| std::string uniformName = key.toLocal8Bit().data(); | ||
| std::string trueUniformName = uniformName; | ||
| if (isArrayUniform) { | ||
| trueUniformName += "[0]"; |
There was a problem hiding this comment.
due to the internals of how our shader management classes work, reflection->uniforms expects the slot to be specified for just the first element of array types, with [0] included at the end of the string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
procedural shaders previously supported uniforms of types float, vec2, vec3, and vec4. this PR adds support for mat3, mat4, vec3[], vec4[], mat3[], and mat4[].
here is a script that demonstrates this feature. it creates a procedural particle entity and places a new particle every time you click on an entity (up to 50 particles in this example but it would support more). in the vertex shader, the click positions (and normals) are sent as a uniform vec3[].