Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild fonts with full charset (NOT -allglyphs) #1172

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

HifiExperiments
Copy link
Member

@HifiExperiments HifiExperiments commented Oct 20, 2024

Closes #1169

ok so what happened here was:

I have regenerated our fonts using this command, and they now properly include Cyrillic characters and much more

@HifiExperiments HifiExperiments added bug Something isn't working needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Oct 20, 2024
@HifiExperiments HifiExperiments linked an issue Oct 20, 2024 that may be closed by this pull request
@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Oct 21, 2024
@ksuprynowicz
Copy link
Member

Works perfectly:
overte-snap-by-X74hc595-on-2024-10-22_14-26-02

@ksuprynowicz ksuprynowicz added QA approved This pull request has been successfully tested and removed needs QA This pull request needs to be tested labels Oct 22, 2024
@ksuprynowicz ksuprynowicz merged commit 9ef544e into overte-org:master Oct 22, 2024
9 checks passed
@HifiExperiments HifiExperiments deleted the allglyphs branch October 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CR approved This pull request has been successfully code reviewed QA approved This pull request has been successfully tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text entities: Cyrillic characters are no longer displayed
2 participants