Rebuild fonts with full charset (NOT -allglyphs) #1172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1169
ok so what happened here was:
-allglyphs
-allglyphs
mangles the property that I treat as the unicode value (How do I output all glyphs, but with the "unicode" field included in the JSON where appropriate? Chlumsky/msdf-atlas-gen#91 (comment))charset.txt
which is just a single line with[0x0,0xFFFF]
and doing:msdf-atlas-gen.exe -font Roboto-Regular.ttf -type mtsdf -fontname Roboto -format png -arfont Roboto.arfont -charset charset.txt
I have regenerated our fonts using this command, and they now properly include Cyrillic characters and much more