-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places App.: Persisted Maturity Filter and Default value for Newbies. #1164
Places App.: Persisted Maturity Filter and Default value for Newbies. #1164
Conversation
Make Maturity Filter persisted and with a default value (Teen & Everyone)
Making the maturity filter persistent is a really nice improvement. |
Adjust the default value for maturity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not well versed in UI code and don't quite understand, what's the deal with the timestamps and INTERCALL_DELAY?
Maybe something in the API needs improving so that this is not necessary?
The html button's onclick is sometime triggered multiple time, this is a parade against this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good :)
This PR makes the Places App. "Maturity" filter persisted in a setting.
It also define the default value that the "Maturity" filter will have for a new user.
The default value will have "teen" and "everyone" set.
(so "adult", "mature" and "unrated" NOT set.)
Please let me know if you have concerns regarding this default value.