Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places App.: Persisted Maturity Filter and Default value for Newbies. #1164

Merged

Conversation

AleziaKurdis
Copy link
Contributor

This PR makes the Places App. "Maturity" filter persisted in a setting.
It also define the default value that the "Maturity" filter will have for a new user.

The default value will have "teen" and "everyone" set.
(so "adult", "mature" and "unrated" NOT set.)

Please let me know if you have concerns regarding this default value.

Make Maturity Filter persisted and with a default value (Teen & Everyone)
@ksuprynowicz
Copy link
Member

Making the maturity filter persistent is a really nice improvement.
I'm worried about unrated not being set though, since that's default value, and most people will never discover this setting. Maybe a popup on first launch would be possible?

Adjust the default value for maturity
@AleziaKurdis
Copy link
Contributor Author

I finally set the default value to: ["adult", "mature", "teen", "everyone", "unrated"] (everything visible)

I evaluated the idea to have a prompt to let the user if he want it restricted or not and frankly it is overkill (implement the communication to push the info to the UI, and probably have custom UI to work in HMD, all that for just for a one time use.)

But since the filter is right in front of our eyes...
image
I think it is not so bad.

What I wanted to address with this PR, is if someone would have set the maturity as restricted, then it will be persisted, protecting from any "dangerous" surprise in the place list. (which wasn't the case today)

It would be always possible to address other restricted content later (not necessarily soon). Like adding a "parental/business control" locking some options in the maturity filter and lock the ability to manage the regions (dir. servers)

Copy link
Contributor

@daleglass daleglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not well versed in UI code and don't quite understand, what's the deal with the timestamps and INTERCALL_DELAY?

Maybe something in the API needs improving so that this is not necessary?

@AleziaKurdis
Copy link
Contributor Author

I'm not well versed in UI code and don't quite understand, what's the deal with the timestamps and INTERCALL_DELAY?

Maybe something in the API needs improving so that this is not necessary?

The html button's onclick is sometime triggered multiple time, this is a parade against this.
It is certainly not expected, but it was happening during the development of this tool and maybe it still happen.

Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good :)

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed needs QA This pull request needs to be tested QA approved This pull request has been successfully tested and removed needs QA This pull request needs to be tested labels Oct 21, 2024
@ksuprynowicz ksuprynowicz merged commit 7ff372f into overte-org:master Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR approved This pull request has been successfully code reviewed QA approved This pull request has been successfully tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants