turn on warnings as errors

overte-org · Oct 21, 2024 · c1d7315 · c1d7315
1 parent 9da839f
commit c1d7315
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -160,7 +160,7 @@ if(NOT DEFINED OVERTE_WARNINGS_ALLOWLIST)
 endif()
 
 if(NOT DEFINED OVERTE_WARNINGS_AS_ERRORS)
-    set(OVERTE_WARNINGS_AS_ERRORS false CACHE BOOL "Count warnings as errors")
+    set(OVERTE_WARNINGS_AS_ERRORS true CACHE BOOL "Count warnings as errors")
 endif()
 
 if(OVERTE_WARNINGS_ALLOWLIST)

diff --git a/assignment-client/src/audio/AudioMixer.cpp b/assignment-client/src/audio/AudioMixer.cpp
@@ -894,7 +894,8 @@ void updateAudioZone(EntityItem* entity, std::unordered_map<QString, AudioMixer:
         audioZone.listeners.push_back(listener.toString());
     }
 
-    audioZone.coefficients = audioSettings.getListenerAttenuationCoefficients().toStdVector();
+    const auto& listenerAttenuationCoefficients = audioSettings.getListenerAttenuationCoefficients();
+    audioZone.coefficients = std::vector<float>(listenerAttenuationCoefficients.begin(), listenerAttenuationCoefficients.end());
 
     /*qCDebug(audio) << "Updated audio zone:" << entity->getID().toString() << "(position:" << t.getTranslation()
                    << ", dimensions:" << t.getScale() << ")";*/

diff --git a/libraries/render-utils/src/RenderCommonTask.cpp b/libraries/render-utils/src/RenderCommonTask.cpp
@@ -321,7 +321,7 @@ class SetupMirrorTask {
         args->_numMirrorFlips += portalExitID != Item::INVALID_ITEM_ID ? 0 : 1;
 
         gpu::doInBatch("SetupMirrorTask::run", args->_context, [&](gpu::Batch& batch) {
-            bool shouldMirror = args->_numMirrorFlips % 2 == (args->_renderMode != RenderArgs::MIRROR_RENDER_MODE);
+            bool shouldMirror = args->_numMirrorFlips % 2 == (args->_renderMode != RenderArgs::MIRROR_RENDER_MODE ? 1 : 0);
             batch.setContextMirrorViewCorrection(shouldMirror);
         });
 

diff --git a/libraries/render-utils/src/ToneMapAndResampleTask.cpp b/libraries/render-utils/src/ToneMapAndResampleTask.cpp
@@ -111,7 +111,7 @@ void ToneMapAndResample::run(const RenderContextPointer& renderContext, const In
         batch.setViewportTransform(destViewport);
         batch.setProjectionTransform(glm::mat4());
         batch.resetViewTransform();
-        bool shouldMirror = args->_numMirrorFlips >= (args->_renderMode != RenderArgs::MIRROR_RENDER_MODE);
+        bool shouldMirror = args->_numMirrorFlips >= (args->_renderMode != RenderArgs::MIRROR_RENDER_MODE ? 1 : 0);
         batch.setPipeline(shouldMirror ? _mirrorPipeline : _pipeline);
 
         batch.setModelTransform(gpu::Framebuffer::evalSubregionTexcoordTransform(srcBufferSize, args->_viewport));

diff --git a/libraries/render/src/render/ResampleTask.cpp b/libraries/render/src/render/ResampleTask.cpp
@@ -167,7 +167,7 @@ void UpsampleToBlitFramebuffer::run(const RenderContextPointer& renderContext, c
             batch.setViewportTransform(viewport);
             batch.setProjectionTransform(glm::mat4());
             batch.resetViewTransform();
-            bool shouldMirror = args->_numMirrorFlips >= (args->_renderMode != RenderArgs::MIRROR_RENDER_MODE);
+            bool shouldMirror = args->_numMirrorFlips >= (args->_renderMode != RenderArgs::MIRROR_RENDER_MODE ? 1 : 0);
             batch.setPipeline(shouldMirror ? _mirrorPipeline : _pipeline);
 
             batch.setModelTransform(gpu::Framebuffer::evalSubregionTexcoordTransform(bufferSize, viewport));