Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: remove JSValue.isEmpty #15128

Merged
merged 2 commits into from
Nov 14, 2024
Merged

zig: remove JSValue.isEmpty #15128

merged 2 commits into from
Nov 14, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented Nov 13, 2024

progress towards zig JSValue stability and safety
making these direct comparisons to .zero makes it clearer to the reader what we're dealing with
and eases the transition to remove .zero later

@robobun
Copy link

robobun commented Nov 13, 2024

@nektro nektro marked this pull request as ready for review November 13, 2024 10:00
@dylan-conway dylan-conway merged commit 35513a9 into main Nov 14, 2024
21 of 23 checks passed
@dylan-conway dylan-conway deleted the nektro-patch-34625 branch November 14, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants