Flatten Swift telemetry dictionary #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GyroJoe
approved these changes
Apr 24, 2024
| } else if (type->is_struct()) { | ||
| out << ".dictionary(" << property_name << ".telemetryDictionary())"; | ||
| out << indent() << "telemetryData.merge(" << property_name << ".telemetryDictionary()) { _, child in child }"; |
There was a problem hiding this comment.
Do you think we should be warning consumers in the case of a conflict?
There was a problem hiding this comment.
We have a lint rule here to check for members in sub-structs and maps with enum keys. We're not able to check at compile-time for maps with string keys. Do you have ideas for how we would warn consumers? FWIW we didn't have any logs for this even in Outlook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten the Swift telemetry dictionary in the telemetryDictionary function as opposed to within the host app