Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update foundry toml file settings #144

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Update foundry toml file settings #144

merged 3 commits into from
Aug 2, 2023

Conversation

iainnash
Copy link
Collaborator

@iainnash iainnash commented Aug 2, 2023 •
edited
Loading

  • Add etherscan configs

oveddan
oveddan requested changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@oveddan oveddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job adding the etherscan stuff, how about adding base, base goerli, mainnet, and goerli to the etherscan settings?

@iainnash
Copy link
Collaborator Author

iainnash commented Aug 2, 2023

Any proper etherscan instance shouldn't need urls.

@iainnash iainnash merged commit 2c7e73e into main Aug 2, 2023
2 of 3 checks passed
@iainnash iainnash deleted the add_pgn_configs_foundry branch August 2, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulkarohan kulkarohan kulkarohan approved these changes

@oveddan oveddan oveddan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iainnash @oveddan @kulkarohan