O/noun 257 manage automated derivatives addition #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOUN-257 Manage (Automated derivatives addition)
Scope
---- Out of scope
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bjfresh
reviewed
Dec 7, 2022
| <Stack gap="x14" pb="x10"> | ||
| <Grid {...props} p="x0"> | ||
| {items.map((nft) => { | ||
| const collectionAddress = nft.token.collectionAddress |
There was a problem hiding this comment.
Should be able to destructure these from nft.token
bjfresh
reviewed
Dec 7, 2022
Comment on lines
+25
to
+30
| tokenId | ||
| collectionAddress | ||
| collectionName | ||
| tokenOwner | ||
| token?.image?.url or token?.image?.mediaEncoding?.poster | ||
| */ |
bjfresh
reviewed
Dec 7, 2022
| image: ImageType | ||
| } | ||
|
|
||
| export function NFTCard2({ |
There was a problem hiding this comment.
Great that this eliminates the useNFTProvider() calls, which seemed to me like a super weird pattern.
bjfresh
reviewed
Dec 7, 2022
| image: any // very bad type from api, FIXME later | ||
| } | ||
|
|
||
| export function ImageWithNounFallback({ |
There was a problem hiding this comment.
Let's move this to an external component?
bjfresh
reviewed
Dec 7, 2022
Comment on lines
+78
to
+93
| const decodedImgSrc = useMemo(() => { | ||
| const imageUrl = image?.url | ||
| if (image?.mimeType === 'image/svg+xml') { | ||
| return imageUrl?.includes('data:image/svg+xml') || | ||
| imageUrl?.includes('https://api.zora.co') | ||
| ? imageUrl | ||
| : `data:image/svg+xml,${imageUrl}` // proper handling of URI-encoded SVG | ||
| } else { | ||
| return image?.mediaEncoding?.poster ?? imageUrl | ||
| } | ||
| }, [image]) | ||
|
|
||
| const srcImg = useMemo( | ||
| () => decodedImgSrc ?? rawImageFallback, | ||
| [decodedImgSrc, rawImageFallback] | ||
| ) |
There was a problem hiding this comment.
I'd suggest moving this all into useRawImageTransform
bjfresh
reviewed
Dec 7, 2022
| className={[titleWrapper, useTitleScroll && titleScroll]} | ||
| style={{ | ||
| /* @ts-ignore-next-line */ | ||
| '--titlePad': titleScroll ? '40px' : '0px', |
There was a problem hiding this comment.
Feels like we can manage this inside of the stylesheet
bjfresh
reviewed
Dec 7, 2022
| } | ||
|
|
||
| export function NFTGrid2({ items, ...props }: NFTGridProps) { | ||
| console.log(items) |
bjfresh
reviewed
Dec 7, 2022
| image, | ||
| tokenName, | ||
| }: Props) { | ||
| console.log('NFTCard2', collectionAddress, tokenId, collectionName) |
bjfresh
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to simplify
NFTGridandNFTCardcomponents: only necessary data, no dependencyNFTObject