fix useContractReads state dumping #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
keepPreviousData : true
to useContractReads to useVotes hook and ProposalActionsMotivation & context
wagmi useContractReads hook was forcing page re-renders due to a bug with state/caching persistence
wevm/wagmi#2878
Took a bit of digging, but I was able to find a parameter that would stop this from happening
keepPreviousData : true
This solves both issues:
Code review
Type of change
Checklist