Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with proposal warning banner #390

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix bug with proposal warning banner #390

merged 1 commit into from
Oct 19, 2023

Conversation

neokry
Copy link
Collaborator

@neokry neokry commented Oct 19, 2023

Description

warning banner renders "0" on some pending proposals

Code review

  • does warning banner render correctly for pending proposals

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview Oct 19, 2023 2:06am
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview Oct 19, 2023 2:06am

@isaaczaak isaaczaak requested review from jordanlesich and isaaczaak and removed request for jordanlesich October 19, 2023 02:05
@neokry neokry merged commit 7695580 into main Oct 19, 2023
2 of 3 checks passed
@neokry neokry deleted the fix-warning-banner branch October 19, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaczaak isaaczaak isaaczaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neokry @isaaczaak