Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to save DAO art #386

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

jordanlesich
Copy link
Collaborator

Description

Before, users could not 'save image as'

Motivation & context

An ::after psuedo-element was blocking the image pointer events. It was being used for drop shadow.

I disallowed pointer events for the psuedo element so that image events could pass through.

Code review

Probably doesn't need it. Two lines of code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

@vercel
Copy link

vercel bot commented Oct 12, 2023

@jordanlesich is attempting to deploy a commit to the Nouns Builder Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview Oct 12, 2023 10:02pm
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview Oct 12, 2023 10:02pm

@jordanlesich jordanlesich merged commit 6d0a1d3 into ourzora:main Oct 12, 2023
0 of 3 checks passed
@jordanlesich jordanlesich deleted the fixPointerEvents branch October 12, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants