FixCreateForm #378
FixCreateForm #378
Conversation
|
@jordanlesich is attempting to deploy a commit to the Nouns Builder Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| formik={formik} | ||
| id={'projectDescription'} | ||
| onChange={(e) => { | ||
| formik.handleChange(e) |
There was a problem hiding this comment.
It looks like the pattern established in the other forms is that we update the store in the handleSubmit -- perhaps we should keep that pattern in this file?
| inputLabel={'Artwork'} | ||
| formik={formik} | ||
| id={'artwork'} | ||
| onChange={formik.handleChange} |
There was a problem hiding this comment.
We should be sure to update the store on submit for this field as well -- in the current build you cannot reupload artwork (which has been a known bug) but this PR reveals the issue, would be great to fix this as well
There was a problem hiding this comment.
Just took a little dive on this one.
There's definitely the issue with not being to upload properly, but it looks like there's another issue with the preview (it still sticks to the old artwork preview, even if I upload new files) , which I suspect is why the formValues weren't being to the store in the first place.
Since there are users who are having issues with the description rn, would it be okay if we get this fix in and then fix the Artwork issue on a separate PR? Seems like there's a lot going on under the hood that I'll need to wade through.
There was a problem hiding this comment.
Just tried again and the entire app crashes for me. I agree with @jordanlesich 's suggestion that we should fix the artwork upload issue in a separate PR.
Description
Fixes blank description issue.
Motivation & context
Users were sometimes not getting description data to the metadata contract. This was a state management issue with the form.
Steps to reproduce.
On the current production build:
This should cause the state to stick to the first value that was entered. But not when we try to update that value.
Code review
Type of change
Checklist