add PUT /api/v1/tree/pin endpoint #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a draft attempt at adding a /api/v1/tree/pin endpoint. this endpoint will pin a json representation of a merkle tree to ipfs. you can see an example of what this code currently produces pinned to `[ipfs://QmXdDyUSsM59MUoeZyDS5uVo8gg4WMenduvehUjP4Hs8KG](https://cloudflare-ipfs.com/ipfs/QmXdDyUSsM59MUoeZyDS5uVo8gg4WMenduvehUjP4Hs8KG)`. open ideas/questions: - should we save ipfs hashes to postgres when we pin them and return them via `/tree` and other endpoints? - should we save every tree by default to IPFS? if we do that, how do we depend on our pinning provider being down/retries/etc. also the latency isn't great as is - even locally pinning was taking 600ms-1s
|
tagging @ryandotsmith - would love your thoughts on this idea/implementation |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a draft attempt at adding a /api/v1/tree/pin endpoint.
this endpoint will pin a json representation of a merkle tree to
ipfs. you can see an example of what this code currently produces
pinned to ipfs://QmXdDyUSsM59MUoeZyDS5uVo8gg4WMenduvehUjP4Hs8KG.
open ideas/questions:
should we save ipfs hashes to postgres when we pin them and
return them via
/treeand other endpoints?should we save every tree by default to IPFS? if we do that,
how do we depend on our pinning provider being down/retries/etc. also
the latency isn't great as is - even locally pinning was taking 600ms-1s
todos if we want to go ahead with merging this: