Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

391 add company picture attribut to jobs #423

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

DipandaAser
Copy link
Member

@DipandaAser DipandaAser commented Jun 11, 2023

Update the post jobs offer handler to accept a new field for the company picture
Add a new handler to retreive the company picture

Why ?
To allow job poster to add their company image on thiers job post

How?
We have added an S3 self hosted object storage called minio

ROUTES:

  • "/jobs" POST: post a job (ther_is a new field called company_image who take a base64 encoding of and image)
  • "/jobs/{jobID}/image" GET: get the job company image
  • "/jobs" GET: get the jobs list (in every job there is a field named has_image bool)

Steps to verify:
move to the backend folder with cd ./backend
run make start-postrges to run an initialized database
run make run to launch the api
run make e2etest to run the test

** Screenshots (optional)

@DipandaAser DipandaAser added the backend backend label label Jun 11, 2023
@DipandaAser DipandaAser self-assigned this Jun 11, 2023
@DipandaAser DipandaAser requested a review from elhmn June 25, 2023 10:15
@DipandaAser DipandaAser requested a review from rakici July 2, 2023 07:31
@DipandaAser
Copy link
Member Author

@rakici review needed

@DipandaAser DipandaAser requested review from elhmn and rakici and removed request for elhmn and rakici July 20, 2023 13:46
@elhmn elhmn force-pushed the 391-add-picture-oder-avatar-attribut-to-jobs branch 2 times, most recently from b5e1d08 to c5f4346 Compare July 30, 2023 08:11
@elhmn elhmn force-pushed the 391-add-picture-oder-avatar-attribut-to-jobs branch from c5f4346 to 4670fb2 Compare July 30, 2023 08:36
@elhmn elhmn force-pushed the 391-add-picture-oder-avatar-attribut-to-jobs branch from 50c438e to 07e3997 Compare July 30, 2023 08:49
Copy link
Member

@elhmn elhmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks great, I left few comments. I also think it would be great to add test for the image size if possible

backend/internal/file-storage/file-storage.go Outdated Show resolved Hide resolved
backend/internal/handlers/job_offers_handler.go Outdated Show resolved Hide resolved
backend/internal/storage/job_offers_db.go Outdated Show resolved Hide resolved
backend/internal/storage/job_offers_db.go Outdated Show resolved Hide resolved
backend/main.go Outdated Show resolved Hide resolved
backend/pkg/models/v1beta/job_offers.go Outdated Show resolved Hide resolved
backend/pkg/models/v1beta/job_offers.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend label
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants