Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gz-common6: depend on spdlog #2747

Merged
merged 3 commits into from
Aug 29, 2024
Merged

gz-common6: depend on spdlog #2747

merged 3 commits into from
Aug 29, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 26, 2024 •
edited
Loading

to go with: gazebosim/gz-common#615

note: gz-utils3 should pull in spdlog so this may not be necessary.

@iche033
Add spdlog dep
c574a88 
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from scpeters as a code owner August 26, 2024 23:30
@iche033
fix
f7b9865 
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 mentioned this pull request Aug 26, 2024
Merged
@iche033 iche033 marked this pull request as draft August 26, 2024 23:37
@scpeters scpeters changed the title gz-common6: Add spdlog dependency gz-common6: depend on spdlog Aug 27, 2024
scpeters
scpeters approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@scpeters
Copy link
Member

note: gz-utils3 should pull in spdlog so this may not be necessary.

to clarify, this isn't explicitly needed, because gz-utils3 is pulling it in, but brew is happier when we explicitly depend on libraries that we link against, so I approve merging it

@iche033 iche033 marked this pull request as ready for review August 29, 2024 00:34
@iche033 iche033 merged commit b048ac2 into master Aug 29, 2024
1 check passed
@iche033 iche033 deleted the common6_spdlog branch August 29, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @scpeters