Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain menu category also for v1 engine #17725

Closed
wants to merge 1 commit into from
Closed

Conversation

sonora
Copy link
Member

@sonora sonora commented Jul 26, 2023

No description provided.

@vshcherb
Copy link
Member

This is strange. We don't support terrain maps for v1, that's why old configure screen should stay for v1. I think you've missed that.

@vshcherb vshcherb closed this Jul 26, 2023
@vshcherb vshcherb reopened this Jul 26, 2023
@sonora
Copy link
Member Author

sonora commented Jul 26, 2023

Hi Victor, no, you probably mis-read the PR, it's considered. I have not changed the logic at all of WHAT we display. Have just aligned the arrangement, put it in a section, just like in v2. With the PR under v1 it looks like this, so it's fully consistent:

Screenshot_20230726-144151_OsmAnd~

(of course with "Terrain" still instead of "Hillshade / Slope", as long as you don't approve the string change.)

@Chumva Chumva changed the base branch from master to r4.5 July 28, 2023 15:02
@Chumva Chumva changed the base branch from r4.5 to master July 28, 2023 15:02
@Chumva
Copy link
Member

Chumva commented Jul 28, 2023

This was added here

@Chumva Chumva closed this Jul 28, 2023
@Chumva Chumva deleted the menu-category-for-v1 branch July 28, 2023 15:33
@dmpr0
Copy link
Contributor

dmpr0 commented Jul 31, 2023

@Chumva add Todo if it was added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants