Skip to content

Commit

Permalink
arm: Remove amd64 node selector (kubevirt#1604)
Browse files Browse the repository at this point in the history
In order to allow running on ARM, remove "kubernetes.io/arch": "amd64"
node selectors.
Replace them with simple "kubernetes.io/os": "linux",
which is part of the default selector if none.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2238723

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval authored Sep 13, 2023
1 parent 2b19c0d commit a17a572
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/network/placement_configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func GetDefaultPlacementConfiguration() cnao.PlacementConfiguration {
},
Workloads: &cnao.Placement{
NodeSelector: map[string]string{
"kubernetes.io/arch": "amd64",
"kubernetes.io/os": "linux",
},
Tolerations: []corev1.Toleration{
corev1.Toleration{
Expand Down
4 changes: 2 additions & 2 deletions pkg/network/placement_configuration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ var _ = Describe("Testing PlacementConfiguration", func() {
PlacementConfiguration: &cnao.PlacementConfiguration{
Workloads: &cnao.Placement{
NodeSelector: map[string]string{
"kubernetes.io/arch": "amd64",
"kubernetes.io/os": "linux",
},
},
Infra: &cnao.Placement{
Expand All @@ -68,7 +68,7 @@ var _ = Describe("Testing PlacementConfiguration", func() {
expectedConfig: cnao.PlacementConfiguration{
Workloads: &cnao.Placement{
NodeSelector: map[string]string{
"kubernetes.io/arch": "amd64",
"kubernetes.io/os": "linux",
},
},
Infra: &cnao.Placement{
Expand Down

0 comments on commit a17a572

Please sign in to comment.