Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tjurina module #4234

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Tjurina module #4234

merged 6 commits into from
Oct 23, 2024

Conversation

Syz-MS
Copy link
Contributor

@Syz-MS Syz-MS commented Oct 23, 2024

Adds Tjurina module and number for CompleteIntersectionGerm.

@afkafkafk13 please review.

Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you. I left you some remarks on the docstrings.

experimental/Schemes/src/Tjurina.jl Outdated Show resolved Hide resolved
experimental/Schemes/src/Tjurina.jl Show resolved Hide resolved
@lgoettgens lgoettgens added topic: schemes experimental Only changes experimental parts of the code labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (7b49bb4) to head (260962b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4234   +/-   ##
=======================================
  Coverage   84.58%   84.59%           
=======================================
  Files         631      631           
  Lines       85012    85023   +11     
=======================================
+ Hits        71911    71923   +12     
+ Misses      13101    13100    -1     
Files with missing lines Coverage Δ
experimental/Schemes/src/Tjurina.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, as soon as the tests have passed.

@joschmitt joschmitt enabled auto-merge (squash) October 23, 2024 10:33
@afkafkafk13
Copy link
Collaborator

@Syz-MS : Failure of the test 1.6, long. ubuntu-latest is due to a problem on the underlying system, not due to you. I will restart the job after all the others have passed.

@joschmitt
Copy link
Member

@Syz-MS : Failure of the test 1.6, long. ubuntu-latest is due to a problem on the underlying system, not due to you. I will restart the job after all the others have passed.

I restarted the job now.

@joschmitt joschmitt merged commit ba9558f into oscar-system:master Oct 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: schemes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants