-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tjurina module #4234
Tjurina module #4234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you. I left you some remarks on the docstrings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4234 +/- ##
=======================================
Coverage 84.58% 84.59%
=======================================
Files 631 631
Lines 85012 85023 +11
=======================================
+ Hits 71911 71923 +12
+ Misses 13101 13100 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, as soon as the tests have passed.
@Syz-MS : Failure of the test 1.6, long. ubuntu-latest is due to a problem on the underlying system, not due to you. I will restart the job after all the others have passed. |
I restarted the job now. |
Adds Tjurina module and number for CompleteIntersectionGerm.
@afkafkafk13 please review.