Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend is_invertible_with_inverse to rings of type MPolyQuoRing{<:MPolyDecRingElem} #4226

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

wdecker
Copy link
Collaborator

@wdecker wdecker commented Oct 22, 2024

…MPolyDecRingElem}`

@wdecker
Copy link
Collaborator Author

wdecker commented Oct 22, 2024

I added an example from intersection theory where the extension is needed.

src/Rings/MPolyQuo.jl Outdated Show resolved Hide resolved
@lgoettgens lgoettgens changed the title Extend is_invertible_with_inverse to rings of type `MPolyQuoRing{<:… Extend is_invertible_with_inverse to rings of type MPolyQuoRing{<:MPolyDecRingElem} Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (88b734c) to head (745e2ca).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
experimental/IntersectionTheory/src/Main.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4226   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         631      631           
  Lines       85009    85012    +3     
=======================================
+ Hits        71908    71911    +3     
  Misses      13101    13101           
Files with missing lines Coverage Δ
...ental/IntersectionTheory/src/IntersectionTheory.jl 100.00% <ø> (ø)
src/Rings/MPolyQuo.jl 92.03% <100.00%> (+0.02%) ⬆️
experimental/IntersectionTheory/src/Main.jl 93.07% <50.00%> (+0.17%) ⬆️

... and 6 files with indirect coverage changes

@wdecker
Copy link
Collaborator Author

wdecker commented Oct 22, 2024

O.k. from my side if lights are green

@fieker fieker merged commit 7b49bb4 into master Oct 23, 2024
30 checks passed
@fieker fieker deleted the Wolfram branch October 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants