Add parent checks to PBW algebra arithmetics

oscar-system · Oct 23, 2024 · ad7306f · ad7306f
1 parent 62cc619
commit ad7306f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Rings/PBWAlgebra.jl b/src/Rings/PBWAlgebra.jl
@@ -266,14 +266,17 @@ function one(R::PBWAlgRing)
 end
 
 function Base.:(==)(a::PBWAlgElem, b::PBWAlgElem)
+  check_parent(a, b)
   return a.sdata == b.sdata
 end
 
 function Base.:+(a::PBWAlgElem, b::PBWAlgElem)
+  check_parent(a, b)
   return PBWAlgElem(parent(a), a.sdata + b.sdata)
 end
 
 function Base.:-(a::PBWAlgElem, b::PBWAlgElem)
+  check_parent(a, b)
   return PBWAlgElem(parent(a), a.sdata - b.sdata)
 end
 
@@ -282,7 +285,8 @@ function Base.:-(a::PBWAlgElem)
 end
 
 function Base.:*(a::PBWAlgElem, b::PBWAlgElem)
-  return PBWAlgElem(parent(a), a.sdata*b.sdata)
+  check_parent(a, b)
+  return PBWAlgElem(parent(a), a.sdata * b.sdata)
 end
 
 function Base.:^(a::PBWAlgElem, b::Int)

diff --git a/src/Rings/PBWAlgebraQuo.jl b/src/Rings/PBWAlgebraQuo.jl
@@ -169,12 +169,12 @@ function Base.:(==)(a::PBWAlgQuoElem, b::PBWAlgQuoElem)
 end
 
 function Base.:+(a::PBWAlgQuoElem, b::PBWAlgQuoElem)
-  @assert parent(a) == parent(b)
+  check_parent(a, b)
   return PBWAlgQuoElem(parent(a), a.data + b.data)
 end
 
 function Base.:-(a::PBWAlgQuoElem, b::PBWAlgQuoElem)
-  @assert parent(a) == parent(b)
+  check_parent(a, b)
   return PBWAlgQuoElem(parent(a), a.data - b.data)
 end
 
@@ -183,7 +183,8 @@ function Base.:-(a::PBWAlgQuoElem)
 end
 
 function Base.:*(a::PBWAlgQuoElem, b::PBWAlgQuoElem)
-  return PBWAlgQuoElem(parent(a), a.data*b.data)
+  check_parent(a, b)
+  return PBWAlgQuoElem(parent(a), a.data * b.data)
 end
 
 function Base.:^(a::PBWAlgQuoElem, b::Int)