-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: A few tweaks #17
Conversation
cgwalters
commented
Nov 28, 2023
- Clarify functionality
- Link to centos-bootc
- Use new image reference
- Target c9s because ELN is more aggressive and has bugs
- Clarify functionality - Link to centos-bootc - Use new image reference - Target c9s because ELN is more aggressive and has bugs
Ah yes, switching to c9s is going to be a problem because of the hardcoded uefi vendor stuff:
Which gets into the bootupd handling, which in turn gets into using bootc install. |
We're going to need to have a real debate about this soon because it's quite important. |
Let's pull all that out into a config then. Build-root repos are already externally defined but embedded at compile time. We can do the same so that the binary is self contained or keep a config with some strings in the repo. |
Sounds like the kind of stuff that should be declared in the container metadata? at least if it declares the distro, we can have a mapping (as I believe we do) from distro to things like UEFI vendor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, in theory we could do that. But this also leads to #18 where bootupd basically handles this dynamically. Now in theory of course we could change the osbuild bootloader code to do the same; I actually don't understand why the vendor is hardcoded instead of being detected today. |
What about splitting this PR? I'm happy to make explicit in the README.md that this is paired with centos-bootc. However, we are not ready to make the centos container the default experience, we still have some issues with them, see #20. Note that @mvo5 is working on a short-term fix for this, before we can fully switch to |
This is obsolete. |
A while ago there was PR#17 that emphasised centos stream9 instead of fedora:eln. We could not take it back then because the iso installer was not quite ready for centos and there were hardcoded EFI names. But now everything is in place so this cherry picks the original changes from Colin. See also osbuild#17
A while ago there was PR#17 that emphasised centos stream9 instead of fedora:eln. We could not take it back then because the iso installer was not quite ready for centos and there were hardcoded EFI names. But now everything is in place so this cherry picks the original changes from Colin. See also #17