-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: enable containers-storage (HMS-3235) #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you are mounting the local storage folder too to the bootc-image-builder container?
Yeah, exactly |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
00fe987
to
889ad7c
Compare
TODO: update readme (will push later) Edit: I think github is having a moment. I've updated the README and pushed the changes... but nothing is showing up right now. |
2cb52a0
to
5f6ac82
Compare
Looks like something in images changed between
|
52fe2c6
to
1ace07b
Compare
Will rebase on top of #244 |
1ace07b
to
5d27492
Compare
dbfac04
to
300908a
Compare
13ca87c
to
ff1da87
Compare
Enable the ability to use local containers from containers-storage rather than pulling containers from a remote registry.
Create a new method to get the `container_ref`, `images` and `target_arch` that we can re-use.
Prepare the test's build command to accept a `local` flag which enable ability to build local images in a follow up commit.
Add an integration tests for the local storage implementation. The test creates a local container and then mounts the local container store to podman, passing the `--local` flag to the build command.
d3452c2
to
816c253
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! ❤️ One nitpick, but it absolutely be done in a follow-up.
Skopeo is now required to test the local containers, so we have to install it.
Enable the ability to use local containers from containers-storage rather than pulling containers from a remote registry.