Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bib/image: set the product name for the ISO #118

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

ondrejbudai
Copy link
Member

Anaconda uses the product name in the buildstamp when calling efibootmgr when setting up the bootloader for containers without bootupd.

Without the product name, the bootloader setup just crashed. This was manually verified using ghcr.io/ublue-os/silverblue-main:39.

See
https://github.com/rhinstaller/anaconda/blob/a8c654b406d128e0e423f4f892511374cc5258f7/pyanaconda/modules/storage/bootloader/efi.py#L88

Closes #114

Anaconda uses the product name in the buildstamp when calling efibootmgr
when setting up the bootloader for containers without bootupd.

Without the product name, the bootloader setup just crashed. This was
manually verified using ghcr.io/ublue-os/silverblue-main:39.

See
https://github.com/rhinstaller/anaconda/blob/a8c654b406d128e0e423f4f892511374cc5258f7/pyanaconda/modules/storage/bootloader/efi.py#L88
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty simple :)

@ondrejbudai ondrejbudai added this pull request to the merge queue Jan 13, 2024
Merged via the queue into osbuild:main with commit 087cfb2 Jan 13, 2024
10 checks passed
@ondrejbudai ondrejbudai deleted the iso-product branch January 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install from generated ISO
2 participants