Fix shellcheck warnings

Signed-off-by: Alexey Gladkov <[email protected]>

data/etc/rc.d/init.d/killall

@@ -21,7 +21,7 @@
 
 processes()
 {
-	for pid in $(cd /proc; printf '%s\n' [0-9]* |sort -g); do
+	for pid in $(cd /proc || exit; printf '%s\n' [0-9]* |sort -g); do
 		f="/proc/$pid"
 
 		[ -e "$f/cmdline" ] ||
@@ -30,6 +30,7 @@ processes()
 		uid='' name='' pid='' ppid='' state='' cmdline='' n='' v=''
 
 		{
+			# shellcheck disable=SC2162
 			while read n v _; do
 				case "$n" in
 					"Name:")  name="$v"  ;;
@@ -40,6 +41,7 @@ processes()
 				esac
 			done < "$f/status"
 
+			# shellcheck disable=SC2162
 			while read -d '' v; do
 				cmdline="${cmdline:+$cmdline }$v"
 			done < "$f/cmdline"

data/etc/rc.d/init.d/mountfs

@@ -126,7 +126,7 @@ stop()
 				continue
 			case "$t" in
 				/dev) ;;
-				$rootmnt|$rootmnt/*) [ -z "${UMOUNT_ROOTMNT-}" ] || printf '%s ' "$t" ;;
+				"$rootmnt"|"$rootmnt"/*) [ -z "${UMOUNT_ROOTMNT-}" ] || printf '%s ' "$t" ;;
 				*) printf '%s ' "$t" ;;
 			esac
 		done
@@ -142,7 +142,7 @@ stop()
 				continue
 			case "$t" in
 				/|/proc) ;;
-				$rootmnt|$rootmnt/*) [ -z "${UMOUNT_ROOTMNT-}" ] || printf '%s ' "$t" ;;
+				"$rootmnt"|"$rootmnt"/*) [ -z "${UMOUNT_ROOTMNT-}" ] || printf '%s ' "$t" ;;
 				*) printf '%s ' "$t" ;;
 			esac
 		done

features/mdadm/bin/generate-udev-rules

@@ -7,6 +7,7 @@
 	fatal "unable to find device name in \`$SYSFS_PATH/dev/block/$1/uevent'"
 
 MD_UUID=
+# shellcheck disable=SC2046
 eval $(mdadm --detail --export "/dev/$DEVNAME")
 
 [ -n "$MD_UUID" ] ||

features/mdadm/data/lib/uevent/handlers/md-raid-member/100-timeout

@@ -26,6 +26,7 @@ is_raid()
 {
 	local MD_UUID='' MD_DEVICES='' MD_METADATA='' MD_DEVNAME='' MD_NAME=''
 
+	# shellcheck disable=SC2046
 	eval $(mdadm --detail --export "/dev/block/$1")
 
 	[ -n "$MD_UUID" ] && [ -f "/etc/initrd/md/${MD_UUID//:}" ] ||

features/sshfsroot/bin/get-dirs

@@ -1,10 +1,8 @@
 #!/bin/bash -efu
 
 DIR="$WORKDIR/root"
-mkdir -p -- \
-	"$DIR/home/root"
-
-mkdir -p -m 700 -- "$DIR/home/root/.ssh"
+mkdir -p -- "$DIR/home/root/.ssh"
+chmod 700 -- "$DIR/home/root/.ssh"
 
 if [ -n "${SSHFS_KEY-}" ]; then
 	cp -- "$SSHFS_KEY" "$DIR/home/root/.ssh/id_key"
@@ -16,10 +14,10 @@ for f in ${SSHFS_KEYS-}; do
 	chmod 600 -- "$DIR/home/root/.ssh/${f##*/}"
 done
 
-[ ! -n "${SSHFS_KNOWN_HOSTS-}" ] ||
+[ -z "${SSHFS_KNOWN_HOSTS-}" ] ||
 	cp -- "$SSHFS_KNOWN_HOSTS" "$DIR/home/root/.ssh/known_hosts"
 
-[ ! -n "${SSHFS_CONFIG-}" ] ||
+[ -z "${SSHFS_CONFIG-}" ] ||
 	cp -- "$SSHFS_CONFIG" "$DIR/home/root/.ssh/config"
 
 printf '%s\n' "$DIR"

tools/create-initrd

@@ -90,8 +90,9 @@ append_progs()
 
 append_libs()
 {
-	local n fn
-	local SEARCH_PATH=$(ldconfig -vNX 2>/dev/null | grep ^/ | cut -d: -f1)
+	local n fn SEARCH_PATH
+
+	SEARCH_PATH="$(ldconfig -vNX 2>/dev/null | grep ^/ | cut -d: -f1)"
 
 	for n; do
 		[ -n "$n" ] ||