-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return timestamps with offset to client for needle info #5964
base: master
Are you sure you want to change the base?
Conversation
32c27f9
to
fb89eea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5964 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 396 396
Lines 38982 38986 +4
=======================================
+ Hits 38498 38502 +4
Misses 484 484 ☔ View full report in Codecov by Sentry. |
oh great, t/ui/18-tests-details.t passes in CI, but not locally. |
for openSUSE Tumbleweed x86_64, see poo#167587 |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Note: t/ui/18-tests-details.t is failing locally for me consistently with this change. It would be good if someone else could double check:
|
Issue: https://progress.opensuse.org/issues/167635
Unfortunately this makes
t/ui/18-tests-details.t
fail, because of a UI problem. The popup is bigger and somehow prevents the click to close the candidates menu.I can't reproduce it in non headless mode, because I don't know which size the window would have.