Skip symlinks in enqueue_git_update_all #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
changed the title
perlpunk
force-pushed
the
no-symlinks
branch
from
2ace7d9
to
22e4527
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5951 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 396 396
Lines 38966 38966
=======================================
Hits 38479 38479
Misses 487 487 ☔ View full report in Codecov by Sentry. |
perlpunk
force-pushed
the
no-symlinks
branch
2 times, most recently
from
24c1ad4
to
e7da05c
Compare
perlpunk
changed the title
kalikiana
approved these changes
Sep 26, 2024
Martchus
approved these changes
Sep 26, 2024
okurz
approved these changes
Sep 26, 2024
No, codecov just didn't run on my force push yet |
perlpunk
force-pushed
the
no-symlinks
branch
2 times, most recently
from
8b49b5a
to
d299c40
Compare
perlpunk
changed the title
|
I reduced this PR to only the first commit about using |
|
@Mergifyio rebase |
I forgot that `-d` is actually true for symlinks. It resulted in the gru task processing over the same realpaths, trying to get a guard for the same path multiple times, which failed and ran int an endless retry. Issue: https://progress.opensuse.org/issues/164898
✅ Branch has been successfully rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that
-dis actually true for symlinks.It resulted in the gru task processing over the same realpaths, trying
to get a guard for the same path multiple times, which failed and ran
int an endless retry.
Issue: https://progress.opensuse.org/issues/164898
I tested it locally with symlinks and could now reproduce the problem. It tries to get a guard for the same directory multiple times and runs into an endless retry.